Comments on: Django Pagination Wrapper http://www.ninjacipher.com/2007/12/27/django-pagination-wrapper/ Tue, 06 Jan 2009 21:46:22 +0000 http://wordpress.org/?v=2.5.1 By: Ninjacipher » Blog Archive » New Django Paginator Example http://www.ninjacipher.com/2007/12/27/django-pagination-wrapper/#comment-183 Ninjacipher » Blog Archive » New Django Paginator Example Mon, 04 Aug 2008 17:07:14 +0000 http://www.ninjacipher.com/2007/12/27/django-pagination-wrapper/#comment-183 [...] release of 1.0. So I did a bit of digging into the new pagination code to see if I could rework my wrapper class to work with the new release. It turns out that with the updates there really is no good reason to [...] [...] release of 1.0. So I did a bit of digging into the new pagination code to see if I could rework my wrapper class to work with the new release. It turns out that with the updates there really is no good reason to [...]

]]> By: mattd http://www.ninjacipher.com/2007/12/27/django-pagination-wrapper/#comment-9 mattd Tue, 08 Jan 2008 01:13:14 +0000 http://www.ninjacipher.com/2007/12/27/django-pagination-wrapper/#comment-9 You are correct on both counts. The displaying page 1 for 0 indexed page count was a design decision on my part as I felt it was more aesthetically pleasing. I can see your point though. I should most likely add in a config flag for that. Also the blindly displaying the page num was an oversight. I've updated the code to deal with that now. Thx for the heads up. Please do send along a link if you add the extra parts in you mentioned as I think that would be very cool. You are correct on both counts. The displaying page 1 for 0
indexed page count was a design decision on my part as I
felt it was more aesthetically pleasing. I can see your point
though. I should most likely add in a config flag for that.

Also the blindly displaying the page num was an oversight.
I’ve updated the code to deal with that now. Thx for the
heads up.

Please do send along a link if you add the extra parts in you
mentioned as I think that would be very cool.

]]> By: timmah http://www.ninjacipher.com/2007/12/27/django-pagination-wrapper/#comment-8 timmah Mon, 07 Jan 2008 21:03:52 +0000 http://www.ninjacipher.com/2007/12/27/django-pagination-wrapper/#comment-8 I just needed pagination for the first time with Django and this sounded like a pretty cool little wrapper. One little thing I noticed and changed. You blindly display whatever page the users requests. If you have three pages and they put in page=14, then current_page is 14, but you are displaying the first page. So, in the get_page method under the except block I just set _current_page to page_number. Well, ok two things, I didn't like displaying "page 1 of x" when page=1 since the pagination is 0 based. I just blindly increment the page and then make sure it isn't greater than self.pages. This is a really good start on removing a lot of the extra code when dealing with pagination in templates. If I get around to adding in a configurable list display of page navigation more than next/previous, I'll be sure to let you know. Thanks I just needed pagination for the first time with Django and this
sounded like a pretty cool little wrapper. One little thing I noticed
and changed.

You blindly display whatever page the users requests. If you have
three pages and they put in page=14, then current_page is 14, but you
are displaying the first page. So, in the get_page method under the
except block I just set _current_page to page_number.

Well, ok two things, I didn’t like displaying “page 1 of x” when
page=1 since the pagination is 0 based. I just blindly increment
the page and then make sure it isn’t greater than self.pages.

This is a really good start on removing a lot of the extra code when
dealing with pagination in templates. If I get around to adding in
a configurable list display of page navigation more than next/previous,
I’ll be sure to let you know.

Thanks

]]>